learnr icon indicating copy to clipboard operation
learnr copied to clipboard

Simplify example_cards.R by using bslib

Open hadley opened this issue 1 year ago • 3 comments

I think there's now only one significant difference: I've switched from a title to a header. This looks better to me, but if you don't agree I'm happy to change it back.

hadley avatar Jun 04 '24 21:06 hadley

Preview: https://rstudio.github.io/learnr/preview/pr815/articles/examples.html Current: https://rstudio.github.io/learnr/articles/examples.html

gadenbuie avatar Jun 10 '24 15:06 gadenbuie

I guess the other difference is that I made it 3 columns to a row, instead of 4.

hadley avatar Jun 10 '24 18:06 hadley

Thanks for this PR! Comparing the bslib result with my initial design here inspired a few improvements to card_image(): https://github.com/rstudio/bslib/pull/1076

gadenbuie avatar Jun 12 '24 19:06 gadenbuie