leaflet icon indicating copy to clipboard operation
leaflet copied to clipboard

Update CSS for better combination with revealjs

Open atusy opened this issue 4 years ago • 2 comments

Regarding to https://github.com/rstudio/revealjs/pull/57 , CSS in some frameworks possibly cause messy results on leaflet tiles. This PR fixes it.

Here is an example messy result with revealjs (see reprex section for code). Although @kazutan made PR on revealjs, I think making PR on leaflet fits better.

image

I did not add tests or update documentation because my change is limited to css.

reprex

Render an Rmd file with a following content.

---
output: revealjs::revealjs_presentation
---

```{r, echo=FALSE}
library(leaflet)
leaflet() %>% addTiles()
```

PR task list:

  • [x] Update NEWS
  • [ ] Add tests (where appropriate)
    • R code tests: tests/testthat/
    • Visual tests: R/zzz_viztest.R
  • [ ] Update documentation with devtools::document()

atusy avatar Mar 04 '20 11:03 atusy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 04 '20 11:03 CLAassistant

using CSS you can manage it :

.reveal section img {  
  border: 0;
  box-shadow: 0;
}

ElenaDatak avatar Jan 27 '21 12:01 ElenaDatak