connectapi icon indicating copy to clipboard operation
connectapi copied to clipboard

Development flow clean ups?

Open jonkeane opened this issue 11 months ago • 3 comments

I'm taking some time to try and do some clean up chores here (clean lint errors, see if we can reduce the heav(ier) dependencies, that kind of thing). I've tried following the top ofhttps://github.com/rstudio/connectapi/blob/main/.github/CONTRIBUTING.md to get tests (and especially integration tests, since that is touching the code I'm looking at) running.

In that process, I've noticed that the version of connect + connect image + R needed bumping. I'm happy to send a PR with those updates to the Makefile and docker-compose files but it also had me wondering if I'm missing a better way that folks are running these?

jonkeane avatar Mar 01 '24 15:03 jonkeane

I think you're on the right track. Unfortunately ever since I moved to an M1 mac, I have not been able to make much use of the integration tests locally 😅 So things have definitely fallen into disrepair.

colearendt avatar Mar 07 '24 14:03 colearendt

(Probably a separate issue) but we should add some tests with mock API responses so we can get test coverage without having to run integration tests against a live connect server.

nealrichardson avatar Mar 07 '24 14:03 nealrichardson

#223

nealrichardson avatar Apr 05 '24 16:04 nealrichardson