bslib icon indicating copy to clipboard operation
bslib copied to clipboard

Use yarn 3.6.3

Open wch opened this issue 2 years ago • 3 comments

bslib currently uses whichever version of yarn is installed on the system. This PR updates it to use a fixed version of yarn, so that the behavior is predictable across systems. (This is how things are set up for the https://github.com/rstudio/shiny repository.)

wch avatar Sep 06 '23 19:09 wch

@cpsievert Do you know if this --production flag is needed?

https://github.com/rstudio/bslib/blob/6797df4665461f9902cc295080382336fa118128/tools/yarn_install.R#L21

We can apparently get similar behavior using yarn workspaces focus --production, but that requires the workspaces plugin and https://yarnpkg.com/cli/workspaces/focus seems to indicate that it's marginally useful.

gadenbuie avatar Sep 06 '23 20:09 gadenbuie

Do you know if this --production flag is needed?

IIRC it's there so we can essentially rename inst/node_modules to inst/lib without having to explicitly pick which dependencies to keep. If we can do that in a smarter way, I'd definitely be willing to consider another approach

cpsievert avatar Sep 06 '23 20:09 cpsievert

The problem I had was that when I ran yarn (version 1.22.17), it errored out because it apparently didn't know how to get the commit of rstudio/shiny specified in yarn.lock. I managed to get it working locally with the change in this PR, but I'm fine with waiting until post-conf before we merge it.

wch avatar Sep 06 '23 21:09 wch