bookdown
bookdown copied to clipboard
Feature: 1380 Sticky Header Update
Adds functionality for a sticky header for mobile
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Is this too risky to merge, or something, @cderv?
I'm trying to decide whether I should wait for it or figure out how to pull in this code when building our books.
I want to find time to test it and see the impact it has, especially on current users. As you have tested it, is this something that some users would want to opt-out ?
My understanding was that it was for mobile only, but the current change seems to also modify the CSS for current style of non mobile view. I don't want to force changes of style to all existing bs4_book.
Maybe we need some media query rule to use the CSS based on size of screen ? https://ui.dev/rwd/develop/browser-feature-support/media-queries-for-common-device-breakpoints