musicdb icon indicating copy to clipboard operation
musicdb copied to clipboard

"Changes not yet saved!" in Lyrics View without changing anything

Open rstemmer opened this issue 3 years ago • 1 comments

There is an issue in the lyrics view that leads to a misleading warning. When showing lyrics, the message "Changes not yet saved!" is shown, even when the lyrics have not been edited by the user.

This message is kind of correct because there are actually differences between the lyrics received from the server and the lyrics handled by the viewer. The viewer removed some invalid/useless characters (like windows-syle line breaks) which leads to differences recognized by the Lyrics Viewer so that this message gets shown.

This message box can be ignored as long es the Lyrics Viewer is not in edit mode. When it is in edit mode, it is save to save the lyrics to get a clean data set. I recommend to actually switch to edit mode and save the clean version of the lyrics.

MusicDB Version: 7.0.0-beta2

rstemmer avatar Jan 23 '21 07:01 rstemmer

It seems that the Show/Hide state of the messages are not reset when new lyrics get loaded.

  1. Edit lyrics of one song
  2. Leave without saving
  3. Open editor for lyrics of another song
  4. Message still visible. Should be hidden.

rstemmer avatar Sep 17 '21 07:09 rstemmer