sklearn-deap icon indicating copy to clipboard operation
sklearn-deap copied to clipboard

Added hall_of_fame attribute such that users can retrieve the k best …

Open cfusting opened this issue 8 years ago • 6 comments

…scores and parameters from a run.

cfusting avatar Oct 11 '17 19:10 cfusting

Huh, ok. I thought for sure we had one of those. It's a little redundant since we have the entire history, logbook, best_scores and best_parameters returned, but if you want the deap native implementation I don't have a problem with it. Please duplicate all your work with the maximize function on the optimize.py file, and make sure it passes (or else change) the test.py script, and your good.

ryanpeach avatar Oct 12 '17 13:10 ryanpeach

if you have to add another output to maximize, please change it so that it returns an extra dict instead so we can start simply naming additional new outputs.

ryanpeach avatar Oct 12 '17 13:10 ryanpeach

I felt like using the other objects to retrieve the hall of fame was a bit circuitous. I'll add the item to maximize.

cfusting avatar Oct 12 '17 19:10 cfusting

This is all ready to go.

cfusting avatar Oct 19 '17 18:10 cfusting

Can you fix the conflicts so I can merge this? Thanks for the pull request!

rsteca avatar Oct 21 '17 22:10 rsteca

I resolved these as best I could but I think another commit occurred around the same time as mine. Perhaps we should have the other merger have a look over my resolutions.

cfusting avatar Oct 22 '17 15:10 cfusting