Radostin Stoyanov

Results 163 comments of Radostin Stoyanov

> This can be useful for runtimes like Java, which often allocate large memory regions without fully using them (e.g. for the heap). For a simple Helloworld Java program, this...

> Code Linter test where I can't understand what he's objecting @simonis Would it be possible to run `make indent` before committing your changes? This should fix the code style...

> What about using constructs like cleanup_free at some places? Could simplify some code paths a bit. Sounds like a good idea! > I think we are trying to avoid...

@indusai99 It might be easier to implement this using [libcriu](https://criu.org/C_API). Here is an example: [test/others/libcriu/test_self.c](https://github.com/checkpoint-restore/criu/blob/150eecc0f8f1b4ee8c0bdc1a902141d103732ee1/test/others/libcriu/test_self.c)

@osctobe Would it be possible to add a test for this functionality?

``` Error (criu/config.c:127): Unsupported configuration file format. Please consult man page criu(8) Error (criu/config.c:238): Unsupported configuration file format. Please consult man page criu(8) Error (criu/config.c:172): Unsupported configuration file format. Please...

I was able to replicate this error on Fedora 37 with `./zdtm.py run -t zdtm/static/socket-tcp-nfconntrack`. It looks like CRIU fails when [`restore_nf_ct(nsid, CR_FD_NETNF_CT)`](https://github.com/checkpoint-restore/criu/blob/bd21ecc2394841c784c931582c4e0902fa38c21b/criu/net.c#L2828) →[`nlmsg_receive(...)`](https://github.com/checkpoint-restore/criu/blob/bd21ecc2394841c784c931582c4e0902fa38c21b/criu/libnetlink.c#L117) is called. ``` (00.028451) 59: Error...

I agree with Adrian. It would be very difficult to handle all possible cases of sensitive data in CRIU and simply ignoring such data is likely to break the restore...

@ajwock What is the use case for this option? Would you be able to add a test?

@hdzhoujie Would it be possible to add tests to verify that the CPU affinity is restored correctly?