slimit icon indicating copy to clipboard operation
slimit copied to clipboard

Proposing a PR to fix a few small typos

Open timgates42 opened this issue 4 years ago • 3 comments

Issue Type

[x] Bug (Typo)

Steps to Replicate and Expected Behaviour

  • Examine src/slimit/tests/test_cmd.py and observe stdou, however expect to see stdout.
  • Examine src/slimit/visitors/minvisitor.py and observe myltiple, however expect to see multiple.

Notes

Semi-automated issue generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

To avoid wasting CI processing resources a branch with the fix has been prepared but a pull request has not yet been created. A pull request fixing the issue can be prepared from the link below, feel free to create it or request @timgates42 create the PR. Alternatively if the fix is undesired please close the issue with a small comment about the reasoning.

https://github.com/timgates42/slimit/pull/new/bugfix_typos

Thanks.

timgates42 avatar Jun 30 '21 21:06 timgates42

Hey @crispinkoech should I review while still in draft?

c12i avatar Nov 29 '23 14:11 c12i

Naah, not yet. Will mark it as ready (and/or ping you) once it's good for review.

On Wed, 29 Nov 2023 at 17:39, Collins Muriuki @.***> wrote:

Hey @crispinkoech https://github.com/crispinkoech should I review while still in draft?

— Reply to this email directly, view it on GitHub https://github.com/c12i/mpesa-rust/pull/92#issuecomment-1832022808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIV6HTTX26DE2RLDCIK6PLYG5CLLAVCNFSM6AAAAAA74NPIKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGAZDEOBQHA . You are receiving this because you were mentioned.Message ID: @.***>

crispinkoech avatar Nov 29 '23 15:11 crispinkoech

Oooft, this MR is too out of sync with the current master commit; @itsyaasir @c12i I suggest I close this and start some new work off of master?

Also, when was the cancel_bulk_invoice.rs module/functionality removed? Can't seem to find a merge request that deleted it.

crispinkoech avatar Aug 04 '24 14:08 crispinkoech