rspec-mocks

rspec-mocks copied to clipboard

Prevent mocks leaking out of their scope when mocked more than once in different nested scopes.

3

### Subject of the issue When mocking a method in an outer and inner scope using combinations of `expect` and `allow`, the mocks leak out of the inner scope. I...

expeehaa

When using keyword arguments in mock expectations and calling with a hash the diff is confusing

1

When you call keyword argument methods with hashes (e.g. if a `method_missing` doesn't have a proper `ruby2_keywords` call or a keyword splat) then the diff is confusing because it looks...

JonRowe

Mocked singleton methods are bound to the mocked class and thus don't respect inheritance

7

### Subject of the issue The `method` variable that's provided to the block in `and_wrap_original` is bound to the mocked class but should instead be bound to `self`, which won't...

jejacks0n

Stubbing method_missing while private method of same name exists does not work

3

### Subject of the issue When you have a class implementing method via `method_missing` and the name is same as private method in parent class, `expect(xx)` does not work. ###...

graywolf-at-work

Kernel.warn when using Forwardable delegators with a null object

4

### Subject of the issue When using Forwardable delegators, if the destination object is a spy, a kernel warning will be emitted of the form: > `warning: [Class]#[method name] at...

bannable

Expect to have_received(method).with({}) fails when method modifies the Hash

9

## What Ruby, Rails and RSpec versions are you using? Ruby version: ruby 2.3.7p456 (2018-03-28 revision 63024) [x86_64-darwin17] Rails version: Rails 5.2.1 Rspec version: RSpec 3.8 ## Observed behaviour I...

bvrooman

deprecate any_instance_of family of methods

6

### deprecate any_instance_of family of methods [rubocop-rspec already discourages the use of allow/expect_any_instance_of](https://www.rubydoc.info/gems/rubocop-rspec/1.6.0/RuboCop/Cop/RSpec/AnyInstance), and a workaround is provided. Also, from the [rspec documentation around these methods](https://relishapp.com/rspec/rspec-mocks/docs/working-with-legacy-code/any-instance), it's argued that using...

HoneyryderChuck

allow_any_instance_of with block followed by expect_any_instance_of without block leads to doubled unshifting of the original object

6

### Your environment * Ruby version: 2.5.x * rspec-mocks version: 3.10 ### Steps to reproduce In a before block I have: ``` before(:each) do allow_any_instance_of(MyClass).to receive(:my_method) { |instance, arg1, arg2|...

contentfree

It may not be guaranteed in future versions.

nobu

Expectation with method missing `self.class.define_method name && send(name)` fails

2

### Subject of the issue This https://github.com/drapergem/draper/blob/master/lib/draper/helper_proxy.rb ```ruby require "bundler/inline" gemfile(true) do source "https://rubygems.org" git_source(:github) { |repo| "https://github.com/#{repo}.git" } gem "rspec", github: "rspec/rspec" gem "rspec-core", github: "rspec/rspec-core" gem "rspec-expectations", github:...

ojab