rsocket-rpc-java icon indicating copy to clipboard operation
rsocket-rpc-java copied to clipboard

Published 20 hours ago • verified publisher icon rsocket

Simplify generator plugin using JProtoc

Open OlegDokuka opened this issue 6 years ago • 6 comments

It would make it easier to support RSocket-RPC-Java plugin if it is written in a more flexible way using a templating engine like mustache or more convenient for codegen like JavaPoet.

This will simplify writing things such as #26 #20 #24

OlegDokuka avatar Jan 07 '19 21:01 OlegDokuka

I guess it will also open a window for some external contributors who have no C++ knowledge and dramatically simplify the build/release process

bsideup avatar Jan 08 '19 08:01 bsideup

I don't want to require a JVM to generate code. C++ supports mustache templates though (https://github.com/no1msd/mstch), and you re-use this in different languages like .net, javascript, etc. Switching to mustache would probably do the most to make this easier than switching a language.

robertroeser avatar Jan 09 '19 19:01 robertroeser

Yeah, sounds good to me, will look at that

OlegDokuka avatar Jan 09 '19 20:01 OlegDokuka

@robertroeser but in 99% cases rsocket-rpc-java will generate java sources during a Java build, and JVM will already be available. Isn't it so?

bsideup avatar Jan 15 '19 11:01 bsideup

Also, I can't see how rsocket-rpc-java's (!) generator can be reused in different languages

bsideup avatar Jan 15 '19 11:01 bsideup

@bsideup @OlegDokuka I tried to implement an alternative Rsocket Rpc based on Salesforce Jprotoc. Additionally I also tried to simplify the API usage (similar to GRPC) by natively supporting tracing, micrometer options. I appreciate if you can take a look and give feedbacks

https://github.com/ilterpehlivan/rsocket-rpc

Thanks

ilterpehlivan avatar Jun 09 '20 20:06 ilterpehlivan