rsocket-kotlin icon indicating copy to clipboard operation
rsocket-kotlin copied to clipboard

Provide a working rsocket-kotlin and Android example

Open yschimke opened this issue 3 years ago • 9 comments

Out of https://stackoverflow.com/questions/67837839/is-it-possible-to-use-rsocket-in-android-with-kotlin

We should provide a working example android test, similar to https://github.com/square/okhttp/tree/master/android-test

yschimke avatar Jun 15 '21 23:06 yschimke

Can i help somehow with such example? Is it suitable for Android in any way?

clayly avatar Jun 30 '21 15:06 clayly

What are you thinking? Add a test that runs in CI as described above?

Alternatively a relatively clean sample that hit demo.rsocket.io would be a good starting point.

yschimke avatar Jul 01 '21 05:07 yschimke

What are you thinking? Add a test that runs in CI as described above?

Alternatively a relatively clean sample that hit demo.rsocket.io would be a good starting point.

I am working on it, diving into the project. Is there something special about contributing what i should know?

clayly avatar Jul 10 '21 20:07 clayly

No, put up something for discussion and it should flush out any concerns. Thanks!

If there is anything we are missing we should clarify it in the docs.

yschimke avatar Jul 11 '21 07:07 yschimke

I did create a demo https://github.com/LittleTrickster/AndroidRSocketDemo (it's a little bloated for a demo) that works both as a server and a client but there is still https://github.com/rsocket/rsocket-kotlin/issues/148 issue that crashes the whole app when the client loses connection to the server. Used unsafe workaround with Thread.setDefaultUncaughtExceptionHandler to prevent the crash for now.

LittleTrickster avatar Jul 21 '21 10:07 LittleTrickster

I did create a demo https://github.com/LittleTrickster/AndroidRSocketDemo (it's a little bloated for a demo) that works both as a server and a client but there is still #148 issue that crashes the whole app when the client loses connection to the server. Used unsafe workaround with Thread.setDefaultUncaughtExceptionHandler to prevent the crash for now.

Have you tried to make it work with okHttp?

clayly avatar Jul 21 '21 13:07 clayly

I did create a demo https://github.com/LittleTrickster/AndroidRSocketDemo (it's a little bloated for a demo) that works both as a server and a client but there is still #148 issue that crashes the whole app when the client loses connection to the server. Used unsafe workaround with Thread.setDefaultUncaughtExceptionHandler to prevent the crash for now.

Have you tried to make it work with okHttp?

Yeah it works just add android:usesCleartextTraffic="true" to manifest.

LittleTrickster avatar Jul 21 '21 13:07 LittleTrickster

@LittleTrickster Is the sample project up to date?

androiddevcoding avatar Aug 03 '23 15:08 androiddevcoding

@nailshakurov It's not.

LittleTrickster avatar Aug 03 '23 15:08 LittleTrickster