rsocket-java icon indicating copy to clipboard operation
rsocket-java copied to clipboard

Rework Payload API and Behavior

Open OlegDokuka opened this issue 4 years ago • 1 comments

Payload API has inconsistent and absolutely confusing behavior:

##Expected case 1

var p = ByteBufPayload.create(data, Unpooled.EMPTY)
assertTrue(p.hasMetadata())
assertEqueals(p.metadata(), Unpooled.EMPTY) 

Unexpected

case 2

var p = ByteBufPayload.create(data, null)
assertFalse(p.hasMetadata())
assertNull(p.metadata()) // fails because Payload always returns Unpooled.EMPTY

OlegDokuka avatar Apr 22 '20 18:04 OlegDokuka

related #771

OlegDokuka avatar Apr 22 '20 18:04 OlegDokuka