rsocket-java icon indicating copy to clipboard operation
rsocket-java copied to clipboard

Fix #1050: Dispose of subscriptions in RSocketRequester and Responder

Open mdindoffer opened this issue 2 years ago • 3 comments

Fix #1050: Dispose of subscriptions in RSocketRequester and Responder

Motivation:

Properly dispose inner subscriptions when terminating a connection.

Modifications:

Calling dispose on Disposable.

Result:

No further Reactor leaks on client disconnects.

mdindoffer avatar Jun 14 '22 13:06 mdindoffer

@OlegDokuka ping

mdindoffer avatar Jul 07 '22 09:07 mdindoffer

@OlegDokuka Can you PTAL or assign someone else who's maintaining this project?

mdindoffer avatar Jul 18 '22 11:07 mdindoffer

@OlegDokuka Can you PTAL or assign someone else who's maintaining this project?

Sorry for the delay. Looking into the proposal, although not sure it is the right change

OlegDokuka avatar Jul 18 '22 21:07 OlegDokuka

should be fixed by reactor netty fix

OlegDokuka avatar Apr 24 '23 07:04 OlegDokuka