Ryan Slawson comments

Results 27 comments of


                                            Ryan Slawson

`riscv-rt`: Cannot be built with `lto = true` if the user defines replacement for `.weak` symbols

I think that sounds about right to me. Just to clarify my understanding of this so I can work on it - do you mean to remove the busy loop-defined...

`riscv-rt`: Cannot be built with `lto = true` if the user defines replacement for `.weak` symbols

I think that could be a workable solution. Frankly I'm entirely unsure of how `.weak` and `.lto_discard` interact, so maybe there's a solution to be found in that direction. I...

`riscv-rt`: Cannot be built with `lto = true` if the user defines replacement for `.weak` symbols

Sorry for the long delay - I've been on holiday with very limited capability to work on this. I should be able to open up a PR sometime this upcoming...

`riscv-rt`: Cannot be built with `lto = true` if the user defines replacement for `.weak` symbols

Got some time to try and start on this today and I quickly discovered I have absolutely no idea how to linker script. I had assumed that just defining `_abort`...

`riscv-rt`: Cannot be built with `lto = true` if the user defines replacement for `.weak` symbols

Nice, okay, so I think then I was most of the way there except for missing the `.global _abort`.

`riscv-rt`: Cannot be built with `lto = true` if the user defines replacement for `.weak` symbols

@MabezDev I do have a min repro for the issue, yes, it's in some code blocks in the issue I opened up on rustc about this: [#133974](https://github.com/rust-lang/rust/issues/133974).

`riscv-rt`: Cannot be built with `lto = true` if the user defines replacement for `.weak` symbols

Huh, I tried almost exactly that and it didn't fix the issue. Wonder what I did differently.