Richard Bailey
Richard Bailey
This looks good, but a couple of questions - I think the behaviour previously was that with a messed up working dir, all the tests would fail, but now they...
So https://github.com/ebu/libadm/blob/4703bdc3fab08011fa9be44334e11122308a2fee/src/elements/audio_content.cpp#L96-L98 should be ```c++ { auto parent = getParent().lock(); if(parent && parent->lookup(id)) { throw std::runtime_error("id already in use"); } } ``` ?
Try profiling build time using (for example) https://devblogs.microsoft.com/cppblog/analyze-your-builds-programmatically-with-the-c-build-insights-sdk/ to identify what is slow. Looks like clang has https://aras-p.info/blog/2019/01/16/time-trace-timeline-flame-chart-profiler-for-Clang/
Yeah, I almost added a "it's not as bad as it looks" comment because of blockformats not being affected. For most 'normal' uses it's fine which is why it hasn't...