rsim
Support for Rails 7.2
I know 7.1.0 just got released with support for Rails 7.1.x (thanks), but is there an ETA for Rails 7.2 support?
https://github.com/rsim/oracle-enhanced/blob/v7.1.0/activerecord-oracle_enhanced-adapter.gemspec
s.add_runtime_dependency("activerecord", ["~> 7.1.0"])
I know Rails 7.2 ActiveRecord has a lot of "Remove deprecated" . . . https://guides.rubyonrails.org/7_2_release_notes.html#active-record
~~I started attempting to upgrade to 7.2, and got stuck. https://github.com/rsim/oracle-enhanced/pull/2422 Anyone willing to give my very limited progress a look, I'd appreciate additional perspectives and/or suggestions for diagnosing.~~
I've made further progress and cut a new PR for consideration. Not all the way there, but a significant step closer. There are now only four remaining test failures locally. #2424
@andynu Thanks for your hard work!
We've pulled your 7.2 branch into one of our projects and have NOT run into a problem.
We'll be trying it on other projects coming up.
Do you have an ETA on an official release?
Hi Dennis, I'm glad the patch has been working well for you, and me too! Alas, I am just a random user; I have no access to make releases.
On Thu, May 15, 2025 at 9:53 AM Dennis Warner @.***> wrote:
dwarner left a comment (rsim/oracle-enhanced#2411) https://github.com/rsim/oracle-enhanced/issues/2411#issuecomment-2883898490
@andynu https://github.com/andynu Thanks for your hard work!
We've pulled your 7.2 branch into one of our projects and have NOT run into a problem.
We'll be trying it on other projects coming up.
Do you have an ETA on an official release?
— Reply to this email directly, view it on GitHub https://github.com/rsim/oracle-enhanced/issues/2411#issuecomment-2883898490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAONGOKA4PBXVOD5VMUTKL26SL4PAVCNFSM6AAAAABPMKZDQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBTHA4TQNBZGA . You are receiving this because you were mentioned.Message ID: @.***>
Whoever tested this, maybe you add an approval so hopefully author attention is captured.
@andynu Thanks for your hard work!
We've pulled your 7.2 branch into one of our projects and have NOT run into a problem.
We'll be trying it on other projects coming up.
Do you have an ETA on an official release?
+1 branch has been running in app ~6mo now. No issues. Thanks for all your work @andynu 🥳 (unfortunately, not able to approve)
@andynu I will make a comment on the PR.
Have you gotten any responses/feedback from the maintainers?
Nope
On May 15 2025, at 12:37 pm, Dennis Warner @.***> wrote:
dwarner left a comment (rsim/oracle-enhanced#2411) (https://github.com/rsim/oracle-enhanced/issues/2411#issuecomment-2884442406)
@andynu (https://github.com/andynu) I will make a comment on the PR.
Have you gotten any responses/feedback from the maintainers? — Reply to this email directly, view it on GitHub (https://github.com/rsim/oracle-enhanced/issues/2411#issuecomment-2884442406), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAAONGNDVP553PICVGFRSRT26S7GPAVCNFSM6AAAAABPMKZDQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBUGQ2DENBQGY). You are receiving this because you were mentioned.
Yes, thank you @andynu . I am testing your branch now and things are looking good. Hoping this can be merged soon.
Thank you @andynu ! I have a quite complex gem that connects to different databases.
Most of my tests worked out of the box with 7.2. Only one test failed. I am not sure if this is a Rails 7.2 behavior, a bug in the adapter, or if I do not know what I am doing.
In my gem, I have a method calling something like
SomeValue.where('value BETWEEN ? and ?', min, max)
The values for min and max come from another DB call. In 7.1 it works, in 7.2 I get the error ActiveRecord::StatementInvalid: OCIError: ORA-01722: invalid number
The issue is that min and max can be a BigDecimal (e.g. 0.23255e3).
The solution was to add .to_f to the variables.
SomeValue.where('value BETWEEN ? and ?', min.to_f, max.to_f)
Hello, I tried @andynu fork on my little application connected to an old Oracle 11 DB. It worked without any problem after the update of the application to Rails 7.2.2.1.
Hope that a new release come out soon! Cheers
I upgraded one of my biggest Rails app (32,000 LOC) to 7.2 using your branch. All tests succeeded and up to now, I cannot find anything, that does not work.
@rsim Are you still maintaining this project?
@dwarner It appears that this repo is mostly maintained by @yahonda. I would love to see @andynu added as a maintainer as someone who managed to contribute a lot to this Gem recently (if that's something they're interested in).
+1. Any updates on this or any sort of plans to maintain this gem?
@yahonda Are you still actively maintaining this gem?
@rsim Are you still maintaining this project?
@dwarner It appears that this repo is mostly maintained by @yahonda. I would love to see @andynu added as a maintainer as someone who managed to contribute a lot to this Gem recently (if that's something they're interested in).
I second that!
If we don't get a response, even though nothing has been posted since 2021, I might try pinging @yahonda here: https://groups.google.com/g/oracle-enhanced
Hi all — pinging this thread since it's been two weeks.
Also, security support for Rails 7.1 (the highest version supported by this gem, aside from forks) ends in 3 months. "Active Support" by the rails team actually ended 3 months ago.
If a few contributors agree, maybe we can make a fork (hopefully temporary until @rsim returns). I say a few so we are not stuck again with a single point of contact and have a basic form of peer review before merging. I think better to avoid a personal fork.
https://github.com/rsim/oracle-enhanced/pull/2424 merged, only new gem version not released yet.
Update: Now released as https://github.com/rsim/oracle-enhanced/releases/tag/v7.2.0.rc1
We've added 7.2.0.rc1 to a test environment. So far, no issues to report.
Oracle enhanced adapter 7.2.0 has been released. Thanks for your patience. https://rubygems.org/gems/activerecord-oracle_enhanced-adapter/versions/7.2.0
Anybody interested in future Rails support, please take a look at #2471 and provide feedback, sorry for the spam but I think it deserves some wider attention.