wad icon indicating copy to clipboard operation
wad copied to clipboard

Added setPitch, proper indenting

Open vincurekf opened this issue 8 years ago • 5 comments

I've just added Wad.prototype.setPitch() (it was not possible to set pitch to single wad on playback), and tried to correct indenting in code and unify it a bit to be easily readable.

vincurekf avatar Oct 19 '15 10:10 vincurekf

I'm not sure what you mean by "proper" indenting. I think 2-space indentations and 4-space indentations are equally valid, but I personally find it uncomfortable to read code with 2-space indentations. I appreciate that you're adding a feature, but please leave the indentation and other aspects of formatting as they were.

rserota avatar Oct 19 '15 16:10 rserota

@rserota

Considering indentations, I would suggest tabs instead of whitespaces, so everybody can adjust his/her editor to display indentation as desired without changing the source code.

phal0r avatar Aug 01 '16 08:08 phal0r

@phal0r When joining a new repository, it is typically the developers job to adapt to the coding standards and layout of the project.

julianpoy avatar Aug 01 '16 16:08 julianpoy

@julianpoy

Yeah, I totally agree. I didn't change it, I was just suggesting a good way :)

phal0r avatar Aug 04 '16 16:08 phal0r

@phal0r WadJS has been updated to use tabs instead of spaces. Thanks for the suggestion.

rserota avatar Jul 02 '20 01:07 rserota