node-inline-assets icon indicating copy to clipboard operation
node-inline-assets copied to clipboard

Comment tags in HTML are not honoured.

Open willhartman opened this issue 7 years ago • 1 comments

If a script tag is commented out then the file backing it might not exist.

The utility still tries to grab the file even though it isn't needed for the HTML to render.

This causes an error which can be resolved by deleting the line instead of commenting it out.

The utility should ignore script tags that are inside HTML comment tags.

willhartman avatar May 21 '18 15:05 willhartman

Yes, I agree. But without a real parser this cannot be achieved easily. For a later version I'll check whether we can use an HTML Parser which generates an AST and work on this instead.

rse avatar Jun 24 '18 10:06 rse