updated code for 2018

[dennisdebel]

See readme for fixes, mostly just broken links. Only tested on OSX 10.10.2

[epsylon]

I will try to review that when possible.. Can you explain a bit more about this pull request. Cloned repo -> https://github.com/epsylon/Border-Check

[dennisdebel]

Hey psy,

Its a quick and dirty fix to get it working in this year on osx. It only involves changing some urls + added some osx specific instructions to the readme.

Maybe not pull worthy at the moment, since the user experience is still a bit broken.

I am working on the code a bit more to fit my needs, but these might not coincide with the needs of the project.

In that case I'd advice to:

• update the map urls and change the default map loaded
• change the lft version check at startup/first launch

My goal is to further develop this into a more general visual traceroute tool that runs smoothly in the browser.

Thx. Dennis

On Wed, 20 Jun 2018 at 16:41, psy [email protected] wrote:

I will try to review that when possible.. Can you explain a bit more about this pull request. Cloned repo -> https://github.com/epsylon/Border-Check

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rscmbbng/Border-Check/pull/3#issuecomment-398775884, or mute the thread https://github.com/notifications/unsubscribe-auth/ADwEUP_-yj87lX6qVo8PEJThBcsKkayYks5t-l8agaJpZM4UsBWQ .

[rscmbbng]

Hey Dennis, first of all thanks and super nice you are using it :) just had a quick look at your patch: main.py:

• the default website should be changed to something more internationally recognized (wikipedia.org?)
• instead of bumping the version number could you actually do a comparison on the number to check whether the version is >= 3.73
• line 1025 the try/except statement doesn't make sense now. Probably can be kept as it was?

Readme I can't verify since I don't have MacOS to test on. But looks good I think!

Also I noticed you pushed a lot of binaries and bc working files. I've added a .gitignore to master branch you can pull so it won't happen in the future!

[dennisdebel]

Hey thx for picking it up. I dont think my fork should be main. It just covers everything to make it work on (outdated) osx atm.

Default website should def be something else. But what should/could it be?

Version check: why? (It works with my hack), why not latest?

There are some redundant binaries yes. I did not realize they would be added to the repo.

I did add some legacy 'offline binary' files to make the osx install work now, and in the future, since several resource are already gone and others will be gone in the future (duh).

This pull request doesnt justify pushing a new version, but it would be nice to publish working code (maybe just update the aforementioned urls?)

On Wed, 20 Jun 2018 at 21:57, rscmbbng [email protected] wrote:

Hey Dennis first of all thanks and super nice you are using it :) just had a quick look at your patcmain.py:

• the default website should be changed to something more internationally recognized (wikipedia.org?)
• instead of bumping the version number could you actually do a comparison on the number to check whether the version is >= 3.73
• line 1025 the try/except statement doesn't make sense now. Probably can be kept as it was?

Readme I can't verify since I don't have MacOS to test on. But looks good I think!

Also I noticed you pushed a lot of binaries and bc working files. I've added a .gitignore to master branch you can pull so it won't happen in the future!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rscmbbng/Border-Check/pull/3#issuecomment-398876811, or mute the thread https://github.com/notifications/unsubscribe-auth/ADwEUDx1EKV0YHhfZ9--xxclCZa55rIZks5t-qk2gaJpZM4UsBWQ .