deft
deft copied to clipboard
rschildmeijer
IOLoop.start() may throw CancelledKeyException
Exception in thread "I/O-LOOP" java.nio.channels.CancelledKeyException at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) at sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:69) at java.nio.channels.SelectionKey.isAcceptable(SelectionKey.java:342) at org.deftserver.io.IOLoop.start(IOLoop.java:77)
Would it be a reasonable solution to change the catch clause from catch(IOException e) to catch(Exception e)?
it's in a single thread environment. i've changed the code to:
/**
* Start the io loop. The thread that invokes this method will be blocked
* (until {@link IOLoop#stop} is invoked) and will be the io loop thread.
*/
public void start() {
Thread.currentThread().setName("I/O-LOOP");
running = true;
long selectorTimeout = 250; // 250 ms
while (running) {
try {
if (selector.select(selectorTimeout) == 0) {
long ms = tm.execute();
selectorTimeout = Math.min(ms, /* selectorTimeout */250);
if (cm.execute()) {
selectorTimeout = 1;
}
continue;
}
} catch (Exception e) {
e.printStackTrace();
}
Iterator<SelectionKey> keys = selector.selectedKeys().iterator();
while (keys.hasNext()) {
SelectionKey key = keys.next();
IOHandler handler = handlers.get(key.channel());
try {
if (key.isAcceptable()) {
handler.handleAccept(key);
}
if (key.isConnectable()) {
handler.handleConnect(key);
}
if (key.isValid() && key.isReadable()) {
handler.handleRead(key);
}
if (key.isValid() && key.isWritable()) {
handler.handleWrite(key);
}
} catch (Exception e) {
e.printStackTrace();
}
keys.remove();
}
long ms = tm.execute();
selectorTimeout = Math.min(ms, /* selectorTimeout */250);
if (cm.execute()) {
selectorTimeout = 1;
}
}
}
well, not exactly, i've moved the try..catch clause around, but essentially, yes, it's just to catch the all the Exceptions so the web server won't exit when there's an unknown exception.
Sorry I'm new to Github, not sure how to do the diff here :(
No problem, will do the diff manually. The best way (I guess) to do a proper diff is a) create a patch and paste/submit it here or on a pastebin or b) fork, commit, pull request. But thats not important. Thanks for the support by the way :)