rf icon indicating copy to clipboard operation
rf copied to clipboard

refactor: keep blank imports

Open pymq opened this issue 4 years ago • 3 comments

Previously blank imports were always removed which prevents using packages for init-only purposes. Updated tests to reflect this changes.

pymq avatar May 28 '21 11:05 pymq

@rsc @mdempsky can you merge it? I have encountered this bug today and that commit fix it

slsyy avatar Sep 01 '21 20:09 slsyy

Sorry for bumping up old issue, but this bug is indeed important, I'd be happy if it is fixed (by merging this PR or otherwise).

When blank imports are removed, the compiler won't complain, and so these incorrect changes are easy to miss.

vearutop avatar Jan 19 '23 12:01 vearutop

@vearutop if you need a great replacement then try https://github.com/uber-go/gopatch

slsyy avatar Jan 19 '23 12:01 slsyy