Russ Cox

Results 790 comments of Russ Cox

Based on the discussion above, this proposal seems like a **[likely accept](https://go.dev/s/proposal-status#likely-accept)**. — rsc for the proposal review group The proposal is at https://github.com/golang/go/issues/68232#issuecomment-2289416684

No change in consensus, so **[accepted](https://go.dev/s/proposal-status#accepted)**. 🎉 This issue now tracks the work of implementing the proposal. — rsc for the proposal review group The proposal is at https://github.com/golang/go/issues/68232#issuecomment-2289416684

Why is the profile entirely "\"? What is your total heap size? Can you post the non-empty profile as well?

Sure, if you think #43669 is done, then feel free to close it. Personally, I would say that the API to access the deep stack traces is runtime/pprof, and we...

They have documentation. https://pkg.go.dev/encoding/binary#pkg-variables It sounds like you are saying gopls does not show the documentation?

The idea that re, err := regexp.Compile(tt.regexp) tt.assertRegexpCompileError(t, err) match := re.MatchString("some string") require.True(t, match) might stop the test with a PASS result during assertRegexpCompileError is surprising at the least....

This proposal has been **[declined as infeasible](https://go.dev/s/proposal-status#declined-as-infeasible)**. — rsc for the proposal review group

I agree with ten-years-ago me from #9096: > I would really rather not. ReadFull exists because Read is *allowed* to return less than was asked without an error. Write is...

This proposal has been **[declined as infeasible](https://go.dev/s/proposal-status#declined-as-infeasible)**. — rsc for the proposal review group