Russ Cox
Russ Cox
It's very unclear to me what CopyFS should do with symlinks. Perhaps we should un-accept #49580. :-) Seriously, if the symlink is to something outside dir, that's probably an error,...
Symbolic links are so awful. I am going to come back to this after Go 1.22 is frozen.
Getting back to symlinks, if we don't want to unaccept #49580 (which would be fine with me but I'm not proposing it), then it seems like we should only accept...
I think the revised complete docs for CopyFS are: ``` // CopyFS copies the file system fsys into the directory dir, // creating dir if necessary. // // Newly created...
Based on the discussion above, this proposal seems like a **[likely accept](https://go.dev/s/proposal-status#likely-accept)**. — rsc for the proposal review group Adding to package os: ``` // CopyFS copies the file system...
No change in consensus, so **[accepted](https://go.dev/s/proposal-status#accepted)**. 🎉 This issue now tracks the work of implementing the proposal. — rsc for the proposal review group Adding to package os: ``` //...
Yes, if you unpack dir/etc/evil into dir/etc->/etc then CopyFS should write etc/evil, the same way that any other code would. It is not CopyFS's job to protect against buggy destinations...
It is good for proposals to focus on API, but implementation is explicitly on topic at least for large proposals, given that it's one of the sections listed in [the...
If we were going to add this function, I think we'd want to use the new iterator functions and write it as func Chunk[T any](slice []T, size int) iter.Seq[[]T] (See...
This proposal has been added to the [active column](https://go.dev/s/proposal-status#active) of the proposals project and will now be reviewed at the weekly proposal review meetings. — rsc for the proposal review...