Russ Cox

Results 790 comments of Russ Cox

Special casing the generic type being float64 would solve sorting []float64, but it wouldn't solve sorting []struct {x float64}. I don't see how we can special case this reasonably. Callers...

This proposal has been added to the [active column](https://go.dev/s/proposal-status#active) of the proposals project and will now be reviewed at the weekly proposal review meetings. — rsc for the proposal review...

The special case in sort seems like a clear decline since it can't be done generally. Retitling to be about this math.FloatCompare that might be helpful for people writing their...

I feel slightly better about this because it is defined by IEEE-754 and we are not making it up. That said, it still seems very niche. The definition is in...

Compare and Compare32 sounds fine. It looks like maybe float32->float64 does preserve signaling and float64->float32 is what squashes it, in which case plain Compare would technically be OK. But maybe...

It sounds like the API is: func Compare(x, y float64) int func Compare32(x, y float32) int and both functions return -1 when x compares before y, 0 when they compare...

Based on the discussion above, this proposal seems like a **[likely accept](https://go.dev/s/proposal-status#likely-accept)**. — rsc for the proposal review group

No change in consensus, so **[accepted](https://go.dev/s/proposal-status#accepted)**. 🎉 This issue now tracks the work of implementing the proposal. — rsc for the proposal review group

This proposal has been added to the [active column](https://go.dev/s/proposal-status#active) of the proposals project and will now be reviewed at the weekly proposal review meetings. — rsc for the proposal review...

There is a question of what type to give this thing. It is both a Reader and a ReaderAt, and we don't have an interface for that type. We would...