Russ Cox

Results 790 comments of Russ Cox

This proposal has been added to the [active column](https://go.dev/s/proposal-status#active) of the proposals project and will now be reviewed at the weekly proposal review meetings. — rsc for the proposal review...

Have all remaining concerns about this proposal been addressed? The proposal is to add ``` package analysis type Pass struct { ... Module *Module // optional } // Module provides...

Based on the discussion above, this proposal seems like a **[likely accept](https://go.dev/s/proposal-status#likely-accept)**. — rsc for the proposal review group The proposal is to add ``` package analysis type Pass struct...

In module mode there really is always a module. We should make Module != nil always, and leave out the fields that we don't have info about. Even &Module{"", "",...

@adonovan points out that code other than x/tools generates Pass structures when running analyzers. Those will not know about Module, so analyzers will have to handle Module==nil. But we can...

No change in consensus, so **[accepted](https://go.dev/s/proposal-status#accepted)**. 🎉 This issue now tracks the work of implementing the proposal. — rsc for the proposal review group The proposal is to add ```...

I understand the default is bad for programmers outside the go repos. But in the subrepos we still want golang/go, without additional configuration just for this command. Perhaps instead: -...

This proposal has been added to the [active column](https://golang.org/s/proposal-status#active) of the proposals project and will now be reviewed at the weekly proposal review meetings. — rsc for the proposal review...

What is the concrete benefit that this would bring? And is it necessary to have in Go 1.18, or should we wait until a future release?