Sashank Ravipati

Results 31 comments of Sashank Ravipati

@zulipbot remove "PR awaiting update" @zulipbot add "PR needs review"

@zulipbot remove "PR awaiting update" @zulipbot add "PR needs review"

I was just updating this right now; looks like I won't need to push changes from my end anymore 😅. Sorry for any added hassle. It now makes sense; initially,...

Updated this PR! Thanks for the review @Niloth-p :)

Thanks for the detailed review, @neiljp! I've updated this PR and added a new commit to change `fetched` to `expected_fetched` for another test written previously. Thanks for pointing out that...

I'll be looking into this, will submit a WIP PR soon.

@neiljp Thanks for bringing this up, I'll look into this :)

LGTM! Great work @Niloth-p 👍 I'm trying to see if we can simplify the conditionals in the test by adding more to the parameterize, but I'm not sure.