Sashank Ravipati
Sashank Ravipati
@zulipbot claim
Hello @enock-arthur, I already have an open PR for this, I'd recommend looking into other issues :)
@neiljp @mounilKshah, does this require any additional changes? I have self-reviewed the code again and @Niloth-p had buddy-reviewed this before. I can't seem to find anything that still needs to...
> @rsashank Other than resolving the expected conflicts you expected with the other PR, this looks essentially good to go except for a few tiny nits from previous comments 👍...
I removed the `expected_code_width` parameter from the `test_create_code_snippet_buttons` test. The expected width of code snippets seems to vary across different versions of Ubuntu and MacOS. Should I reintroduce the test...
@zulipbot add "PR needs review"
Updated this PR :) @zulipbot add "PR needs review"
Thanks for the detailed feedback @Niloth-p! I've updated the PR. I still need to figure out where the language data was tagged in the previous version of Zulip markup, but...
@zulipbot claim
@neiljp, I had tests going on this month, so couldn't get back to this. Anyways, I've updated the PR, addressed the other part of the issue. I believe it's ready...