clearly
clearly copied to clipboard
Tox, Pipenv, Docker (-compose) and a sketch of a client cli
Hey hows it going; I moved a bunch of stuff into a new workflow let me know how you feel about it! The client isn't done yet but I'd like some feedback first. I need to add the dist/dev tools to the pipfile still (or you can as an exercise 😉) I also had some issues with pytest sugar
Does the client stuff look good-ish? Should I keep going with that? @rsalmei
Hello @jrabbit, how are you? I'm so sorry for the delay, was away for a while...
Anyway, I'll take a more in depth look in your PR, but I do like the client stuff! Some things we would need to tweek a little, like maintainer and docker-hub 😄 And finally, I'm not sold on pipenv yet, don't know if it would be nice to have in here yet.
Would you mind merging into another branch of mine, and I made the tweaks in there?
Hey guys, I also tried to make this tool work in a container with no luck. I didn't notice this PR and will give it a try! My main issue is with gRPC, which I don't know well. I just can't make the client connect to the server inside the container. All I get is connection refused... I have been pulling my hair for an entire day now.
Hey @nvictor !
Probably you only need to expose the container port to the host. Do a docker ps
and verify the ports section.
I need to find some time to get back to this... I have my own implementation of docker image that is almost completed...
@rsalmei: I loved the @jrabbit initiative, I found it before proposing something similar. What do you think about it?
I would like to have a clearly official container to use in my infrastructure.
In addition to the @jrabbit example, I think that we should consider:
- using the broker as an environment variable in the server-side;
- using the server-side URL as an environment variable in the client-side.