rrweb icon indicating copy to clipboard operation
rrweb copied to clipboard

Published 20 hours ago • verified publisher icon rrweb-io

bugfix: Sort attributes to make `rr_*` attributes handled last

Open Juice10 opened this issue 3 years ago • 4 comments

rr_dataURL overwrites src attribute, because of this we need to evaluate rr_dataURL last so src doesn't accidentally get overwritten again.

Juice10 avatar Aug 22 '22 13:08 Juice10

Had a chat with @eoghanmurray and @Mark-Fenng, I'm going to do a refactor which eliminates the loop overhead.

Juice10 avatar Sep 16 '22 10:09 Juice10

I think you've got the alternative version without the specialAttributes array, but with the boolean flag?

@eoghanmurray I did some performance tests and this one was faster so I ended up going with this

Juice10 avatar Sep 21 '22 14:09 Juice10

Cool, happy to approve! This way is also elegant now that I see it. I thought the specialAttributes was from before Friday when we had a chat about it.

eoghanmurray avatar Sep 21 '22 15:09 eoghanmurray

@eoghanmurray thanks Eoghan! Yes it was from our chat initially. But it got deleted and then came back again

Juice10 avatar Sep 21 '22 16:09 Juice10