rrweb icon indicating copy to clipboard operation
rrweb copied to clipboard

fix: console assert only logs when arg 0 is falsy

Open pauldambra opened this issue 1 year ago • 2 comments

fixes https://github.com/PostHog/posthog-js/issues/1280

when someone calls console.assert the console recorder always captures as if the log was shown in the console

but...

The console.assert() static method writes an error message to the console if the assertion is false. If the assertion is true, nothing happens.

from https://developer.mozilla.org/en-US/docs/Web/API/console/assert_static

this changes the recorder to only capture when the assertion is false, and not to log the first argument, which brings the recorded logs into line with what the browser would do

technically this is a breaking change since folk could be depending on this incorrect behaviour, i chose not to wrap it in config allowing people to opt in to this new behaviour to keep the change simpler (but open to adding that if necessary)

my educated guess is that use of console.assert is pretty rare

pauldambra avatar Jul 02 '24 11:07 pauldambra