rrweb icon indicating copy to clipboard operation
rrweb copied to clipboard

fix(snapshot): dimensions for blocked element not being applied

Open billyvg opened this issue 2 years ago • 3 comments

Dimensions are not being properly applied when you seek to a position in the replay. Need to use setProperty, otherwise the style attributes get lost. This was happening when node was an RRElement.

billyvg avatar Oct 20 '23 14:10 billyvg

⚠️ No Changeset found

Latest commit: a171d1e269f3c5607b8a4c929d0e46eb07f154af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 20 '23 14:10 changeset-bot[bot]

Thank you for the contribution and for contributing tests :)

To further understand: this was a problem with RRDom but the original code was fine if applied in a real DOM context?

eoghanmurray avatar Nov 09 '23 08:11 eoghanmurray

@eoghanmurray correct, the test I added in rebuild.test works prior to this change.

billyvg avatar Dec 18 '23 20:12 billyvg