credo icon indicating copy to clipboard operation
credo copied to clipboard

feat: warn on dbg calls

Open ding-an-sich opened this issue 3 years ago • 2 comments

Implements a warning for calls to the dbg/0 or dbg/2 Kernel fns.

I used the IO.inspect check as a reference.

ding-an-sich avatar Sep 02 '22 14:09 ding-an-sich

I decided to not check for the use of Macro.dbg/3 because that function could be used as a fallback when building custom backends for dbg().

ding-an-sich avatar Sep 02 '22 21:09 ding-an-sich

I have streamlined the way we check if a given :dbg call should be a warning or not. If the user attempts to override the auto-imported dbg fns dbg/0, dbg/1, dbg/2 he'll get a compile error, so we shouldn't worry about those.

ding-an-sich avatar Sep 03 '22 13:09 ding-an-sich

@rrrene, any chance to get this rolling again? Not sure how to tackle the red CI checks.

ding-an-sich avatar Dec 06 '22 10:12 ding-an-sich

@ding-an-sich Thx! :+1:

rrrene avatar Dec 09 '22 17:12 rrrene

This is part of Credo v1.7.0-rc.1 :+1:

rrrene avatar Dec 31 '22 15:12 rrrene