credo icon indicating copy to clipboard operation
credo copied to clipboard

[956] Add test and maybe a fix for modules passed as arguments

Open tpitale opened this issue 3 years ago • 1 comments

Related to #956

I want to check in early to make sure I'm on the right path.

When a module is passed as an argument to a function, it should maybe be aliased?

What I'm actually trying to fix is probably when a module is passed to a macro and not aliased. I may try to update the PR if I'm on the right path.

tpitale avatar Aug 03 '22 17:08 tpitale

This is really great. Can you introduce a param to the check that allows users to deactivate this behaviour?

Something like ignore_simple_module_references (please use a better name if you have suggestions ^^)^.

rrrene avatar Aug 05 '22 18:08 rrrene

I am closing this for age/inactivity.

If you find the time to make the final changes, please feel free to re-open this issue at your discretion.

rrrene avatar Feb 03 '23 21:02 rrrene

@tpitale I closed this in error. It is now merged. Thx for your contribution! :+1:

rrrene avatar Feb 03 '23 22:02 rrrene