provider icon indicating copy to clipboard operation
provider copied to clipboard

fix: resolve Split import conflict by hiding Flutter's Split class

Open naghinezhad opened this issue 5 months ago • 1 comments

  • Hide Split from flutter/material.dart import to avoid naming conflict
  • Keep using Split from devtools_app_shared/ui.dart
  • No UI changes, only resolves compilation error

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a naming/import conflict in the devtools extension to prevent potential runtime issues; no UI or public API changes expected.
  • Tests

    • Reduced stress/scale in a provider test to make the test suite more efficient and reliable.

naghinezhad avatar Sep 17 '25 21:09 naghinezhad

Walkthrough

Updated one import to hide the Split symbol to avoid a name conflict, and reduced the iteration count in a test from 1500 to 500 providers; no API or control-flow changes.

Changes

Cohort / File(s) Summary
Import resolution
packages/provider_devtools_extension/lib/src/provider_screen.dart
Changed import 'package:flutter/material.dart'; to import 'package:flutter/material.dart' hide Split; to resolve a symbol conflict. No other changes.
Test adjustments
packages/provider/test/null_safe/multi_provider_test.dart
Reduced loop iterations in "Supports a large number of providers" from 1500 to 500, decreasing the number of Provider<int>.value instances created. No other logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • rrousselGit/provider#906 — Appears related: likewise reduces the "Supports a large number of providers" test from 1500 to 500 providers and touches MultiProvider handling.

Poem

I twitched my nose at a naming spat,
Hid Split where conflicts sat;
Fewer providers in a test I fixed,
Hops are smooth, the code's betwixt—
A rabbit's joy in tidy bits. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change: hiding Flutter's Split symbol from the material import to resolve a naming/import conflict so the file uses Split from devtools_app_shared/ui.dart, which matches the changed import in the diff and the PR objectives noting a compilation-only fix with no UI or API changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 17 '25 21:09 coderabbitai[bot]