Mandatory Initial Data removed

[kirchesch]

Most of the times initial data is manually set to null by the user

[rrousselGit]

Hello! I suppose that since the 6.0.0, such change should be reasonable.

Could you add tests though?

[codecov[bot]]

Codecov Report

Merging #759 (4bea63e) into master (4bea63e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 4bea63e differs from pull request most recent head 1bb6fb6. Consider uploading reports for the commit 1bb6fb6 to get more accurate results

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          12       12           
  Lines         728      728           
=======================================
  Hits          723      723           
  Misses          5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kirchesch]

Hey @rrousselGit i created a test area here: https://github.com/KircheschContributions/FlutterIssues

Just modify the main() function to run providerPrTestMain(); instead of userChangesStreamingOldDataMain();

I have tested and it is working fine, the test is plug and play, i hope this is what you meant by provide tests

[rrousselGit]

No, I meant adding widget tests in the test folder of the package.

[kirchesch]

I added the tests, i did not knew how they worked, started using flutter recently, good to know about it

[rrousselGit]

Hello! I apologize for the slow review. This went off my radar.

That's technically breaking, which is problematic.
Folks could be doing updateShouldNotify: (a, b) => a.equal(b) without issue. Now they'd have to use ? or !

For that reason alone and the fact that Provider is in long-term maintenance mode, I don't think we should go forward with this change.

I really appreciate your effort though, and apologize once again for the slow review.