freezed icon indicating copy to clipboard operation
freezed copied to clipboard

Generate documentation for copyWith and toJson

Open rekire opened this issue 10 months ago • 3 comments

Resolves #1068

I tried to minimize the changes. This PR also corrects the position of the @override for some cases where the override was above the documentation.

rekire avatar Apr 12 '24 20:04 rekire

⚠️ No Changeset found

Latest commit: 839bc3bf48ac512124c1776f690f7f659852c38b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 12 '24 20:04 changeset-bot[bot]

@rrousselGit I noticed that you merged a dependabot PR, so you are working today. Is there anything in my PR I should change?

rekire avatar Apr 16 '24 12:04 rekire

Sorry I forgot this comment. I'll check that this weekend

rekire avatar May 22 '24 06:05 rekire

Do you still wish to work on this?

rrousselGit avatar Jul 08 '24 05:07 rrousselGit

To be honest I totally forgot about this PR. I need to check my PR to find out what changes are still required. Might be someone else would be quicker, but I want to finish what I have started. Thank you for the reminder.

rekire avatar Jul 08 '24 06:07 rekire

@rrousselGit did I catch all the missing parts? The last time I checked the generated code everything was documented. I am not sure why I missed those.

rekire avatar Jul 08 '24 15:07 rekire

It sounds good. Do you mind refactoring the doc into a getter on data? So that we don't have multiple duplicates of the same doc in the source.

rrousselGit avatar Jul 09 '24 04:07 rrousselGit

@rrousselGit done

rekire avatar Jul 09 '24 05:07 rekire