Remi Rousselet

Results 1774 comments of Remi Rousselet

Hello! Sorry for the delay. We've been pretty busy with the Flutter Vikings. Let's do what we ca to merge this.

I don't like the changes introduced for `List` & co. cloud_firestore_odm currently voluntarily doesn't contain logic for how to encode an object. Now that Dart has enum "classes", I'd instead...

Could you maybe remove the logic for `List` & co? These are a bit controversial. We could merge simple enum support without those first Also I think it'd be valuable...

> It has already been hard enough to get anything pushed through on the ODM I apologize for the slow review. These past few months have been very busy >...

Ultimately I think this PR tries to do two different things: - It adds support for `whereEnum/orderByEnum` & list variant - It tries to add support for complex objects in...

I've created an issue on json_serializable related to what would be needed for truly fixing 2: https://github.com/google/json_serializable.dart/issues/1198

> We can probably do that. Worse case we can always make our own (expensive) update by getting the doc, merging it in code (on our end), deleting the old...

@Lyokone no, there's a lot more to it than this There's some disambiguation to do. For example what if the model contains a property called `path`? We don't want the...

Attaching the snapshot is counter-productive IMO. If that solution is fine with you, then you could directly pass the Firestore snapshot instead of passing only the document content. The purpose...

Enums are a bit difficult to support at the moment, because the ODM is unaware of how they are serialized We can start with supporting only the `Enum.value.toString()`. But supporting...