Robin Heinemann

Say I have a instance like this: ```python Instance("MMCME2_ADV", p_BANDWIDTH="OPTIMIZED", i_RST=mmcm_reset, o_LOCKED=mmcm_locked, p_REF_JITTER1=0.01, p_CLKIN1_PERIOD=10.0, p_CLKFBOUT_MULT_F=30.0, p_CLKFBOUT_PHASE=0.000, p_DIVCLK_DIVIDE=2, i_CLKIN1=ClockSignal("clk100"), i_CLKFBIN=mmcm_fb, o_CLKFBOUT=mmcm_fb, p_CLKOUT0_DIVIDE_F=10.0, p_CLKOUT0_PHASE=0.000, o_CLKOUT0=ClockSignal("mmcm_clk1"), p_CLKOUT1_DIVIDE=2, p_CLKOUT1_PHASE=0.000, o_CLKOUT1=ClockSignal("mmcm_clk2")) ``` I would like...

No and they could even have phase shifts.

Yes thats what I meant by > Furthermore it would be nice to be able to create clocks from the simulation models to make it posible to simulate things with...

Then maybe I misunderstood this: > [...], but I'm not sure what the API would look like. I am not sure what you have planned for the simulation models that...

> Ah right so if your Instance can be replaced with a normal nMigen module then absolutely nothing special needs to be done because you can wrap it with a...

> You can't. I was only talking about the replacement of `Instance`s with `Module`s for simulation here. It is a fundamental limitation of nMigen that you can't use a normal...

@alanvgreen Some things that came to mind: > ## On the Meaning of _valid_ and _ready_ > > There are plenty of valid that an endpoint might either ignore _valid_...

Something seems to be wrong here. This testcase: https://gist.github.com/rroohhh/acb6247f7634e4e68d53604c4c3f88b1 fails in debug mode with ``` thread 'main' panicked at 'assertion failed: `(left == right)` left: `[207]`, right: `[170]`', src/bin/testcase.rs:52:9 ```...

@pacak thank you for the swift response and fix

This still compiles fine for me without any changes, no idea why you are running into those errors. @jwilm Any interest in merging this?, A better alternative is probably #74,...