Rob Gill
Rob Gill
I don't know about this. I know it would make a lot of sense for a website over a slow connection, especially bloated websites that pull in crud from everywhere....
Realistically the actual work that makes it possible was back done when FTL stopped using sudo when spawning shell commands (I think for updates and possibly restarts at one point?).
> could this also be a potential fix for #1547 as well? The pihole script itself still needs to be called at an elevated privilege to be able to do...
I believe this should have been closed by #3569
I like the idea of having these identified, but I wonder about the display style suggested. No other circumstance adds a wikipedia link under each corresponding entry in the table...
If a string is chosen to stand in place of the vendor identifier, would be better to set it in FTL? That way whatever string is chosen could be added...
I have no special insight on when reviews happen, I'm just another contributor. But I'm happy to give my input here. My concern would be that although dehydrated is listed...
> We should instead depend on just `doas` and detect which utility the user has installed, and use that one for all operations requiring user changes. This seems sensible. If...
An alternate approach (linked PR) is to not mandate any particular elevation command even on a distro by distro basis, by instead using runuser to drop to the pihole user...
> I noticed you still kept the code to check for `sudo` or `doas` - is this extendable to `su` as well? I believe it has an option to run...