antlr4rust icon indicating copy to clipboard operation
antlr4rust copied to clipboard

XXX_all returns all TerminalNode regardless of type

Open oovm opened this issue 1 year ago • 3 comments

If there is more than one TerminalNode type in the child node, XXX_all cannot obtain the correct leaf node type, and children_of_type will return all TerminalNode.

image

For example, the results returned by STRING_TEXT_all here include STRING_START and STRING_END

oovm avatar Sep 29 '23 14:09 oovm

Can you check that this is not already fix by https://github.com/rrevenantt/antlr4rust/pull/58 ?

newca12 avatar Oct 07 '23 13:10 newca12

Where can I download pre-built jars? I don't know how to build a specific branch version.

oovm avatar Oct 07 '23 13:10 oovm

This PR is not merged yet, you have no other choice than built it yourself. Github now allow to fetch PR locally : https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

newca12 avatar Oct 07 '23 13:10 newca12