antlr4rust icon indicating copy to clipboard operation
antlr4rust copied to clipboard

Update uuid version definition

Open weigangd opened this issue 2 years ago • 2 comments

Since uuid >= 1.0 exists now it would be nice to make the uuid version a little more versatile. The proposed change fixes uuid version mismatches when using this crate with together with uuid >= 1.0.

weigangd avatar Aug 22 '22 09:08 weigangd

Hmm.. i guess i am missing something but iirc if you are also using uuid >= 1.0 cargo should happily build two separate versions of it and since uuid types are not exposed in public api it wouldn't cause any mismatches. Also i don't thinks features you have added are required.

So overall i don't see a reason why it is not just a simple version bump, i.e. uuid = "1.*"

rrevenantt avatar Aug 29 '22 09:08 rrevenantt

Yes, you are right. It was a copy and paste mistake - sorry for that. The features are not necessary and a simple version bump is enough. I changed it to uuid = "1.*".

weigangd avatar Sep 06 '22 07:09 weigangd