Ryan Reno

Results 26 comments of Ryan Reno

I'd like to add a vote to the idea to replace `ALWAYS_LOG_WITH_STREAM` with this by removing the old and renaming this macro you're adding to `WTF_ALWAYS_LOG_WITH_STREAM`.

I think there's a problem with the TrustedTypePolicyOptions callbacks. They're by default strong references which makes them GC roots which is a memory leak footgun. I would suggest since you're...

> The style linter wants me to name 3 variables the same thing and protector or protectedNullptr doesn't really feel great either way? I'm not sure what the appropriate thing...

It's this style rule: https://webkit.org/code-style-guidelines/#names-protectors

> > It's this style rule: https://webkit.org/code-style-guidelines/#names-protectors > > Even if I change them to be called protectedCreateXXX it still complains that it's incorrectly named? The checker is probably getting...