Ryan Reno
Ryan Reno
Thank you @dholbert ! I actually landed a patch in WebKit to match Gecko's behavior (I wasn't anticipating a resolution so quickly) so I'll work to get that reverted. https://commits.webkit.org/253389@main
I got it working but only if I remove onload/onerror handlers from the tests. We're not firing events when a prefetch load completes or has an error. I'm not sure...
Ok I guess we [SHOULD be sending these onload/onerror events](https://w3c.github.io/resource-hints/#load-and-error-events) which WPT in effect mandates we do. We're timing out in the allowed tests waiting for load events and in...
Still a WIP. Just need to get the events firing.
New approach: Write tests that don't rely on onload/onerror handlers.
> So we generate the relevant events in WKTR, but not when shipping? That's right. The `internals.addPrefetchLoadEventListener` essentially flips a boolean in the HTMLLinkElement which allows it to send the...
Well that didn't work!
Closing as very stale. I'll try again.
Could you please describe what the quirk does in the commit message?
LGTM thanks for making that change to help avoid typos. (don't have r+ authority yet)