serverless-add-api-key Not handling skip creation part in case of api key not defined for a stage

Not handling skip creation part in case of api key not defined for a stage

Open sromic opened this issue 3 years ago • 12 comments

Default an apiKey array to an empty array in case of api keys not defined for a stage.

Aug 20 '21 11:08 sromic

@sromic - can you please update the version in package.json so that this can be merged

Jan 06 '22 16:01 rrahul963

@sromic - can you please update the version in package.json so that this can be merged

@rrahul963 sorry, I missed this :S. I've merged from your master, so it should be up to date with all new changes.

Sep 05 '22 11:09 sromic

@rrahul963 any plans to have this PR merged?

Jul 31 '23 08:07 sromic

@sromic - can you update the version on package.json file and run the builds

Jul 31 '23 14:07 rrahul963

@rrahul963 done. Please review and merge is looks good. Ty!

Jul 31 '23 16:07 sromic

@rrahul963 any plans to merge this PR? It's been sitting for a while now :)

Apr 11 '24 14:04 sromic

mm maby , same issue when run sls remove ?, error in line 407 TypeError: apiKeys is not iterable

Apr 11 '24 22:04 cvargas-xbrein

mm maby , same issue when run sls remove ?, error in line 407 TypeError: apiKeys is not iterable

could be, let me revisit that as well, ty!

Apr 12 '24 08:04 sromic

@cvargas-xbrein , @rrahul963 ty, added this for remove hook as well.

Apr 12 '24 09:04 sromic

Hi @cvargas-xbrein, @rrahul963 I would appreciate a review to this PR. Ty!

Apr 16 '24 18:04 sromic

Hi @cvargas-xbrein , @rrahul963 any news on getting this reviewed and potentially merged? Ty in advance!

May 21 '24 13:05 sromic

@rrahul963 sorry for bothering, any plans to have this reviewed and merged in? Thanks!

Jul 03 '24 06:07 sromic