rr icon indicating copy to clipboard operation
rr copied to clipboard

Run ASAN on CI

Open Keno opened this issue 2 years ago • 4 comments

We gained a CMake option to run with ASAN in https://github.com/rr-debugger/rr/commit/ca91da0cfdc76d399c48fecd21b584447bbccbe3. @DilumAluthge can you add an appropriate CI config? Maybe allow fail for now, since I think there are still issues.

Keno avatar Apr 03 '23 20:04 Keno

There are still issues, mostly with nested* tests. I tried to solve them for me, see the patches in #2890. I put there also a patch to default to ASan to see how CI would work, see run 1064, run 1065, run 1066. The x86_64 run shows a few more failing, which I currently cannot reproduce. And the arm64 has also some failures and exceeds the 30 minutes time limit.

(I got the impression x86_64-CI runs done at exclusive-amdci1.0 are showing a few extra failures on regular runs: 1049, 1053, 1061, 1063, 1065 . Is there maye some configuration difference?)

bernhardu avatar Apr 07 '23 19:04 bernhardu

can you add an appropriate CI config?

Sure. What's the command to run? Is it e.g. make asan?

DilumAluthge avatar Apr 08 '23 20:04 DilumAluthge

Add -Dasan=ON to the cmake line.

Keno avatar Apr 08 '23 20:04 Keno

Hello, while trying to run on a specific host I looked a little through the buildkite config. Is there more to it to add this properly, or would something like this patch be already enough? This produced this run. (The running times are not correct as most tests are disabled here.)

bernhardu avatar Apr 18 '23 14:04 bernhardu