Building rr using external blake2 and brotli

[wcohen]

Fedora packaging guidelines discourage the use of bundled packages for building rpms.

https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

Fedora has system copies of blake2 (libb2) and brotli available. Is there some way to configure rr to use the system versions of those packages?

It looks like some patching is needed as there is a hard coded include to the third-party directory: $ grep -r third-party PackCommand.cc:#include "../third-party/blake2/blake2.h"

[rocallahan]

We don't support that right now but I'd accept a patch to support it. We aren't patching blake2 or brotli and they're very stable so it shouldn't be hard.

[rocallahan]

To be clear I'd accept a patch to opt into that.

[lu-zero]

This would be simple enough using FindPkgConfig, which version of CMake rr should support?

[rocallahan]

Current minimum version is 3.12. We could raise it a bit if we need to.

[wcohen]

It looks like that would be useable with Fedora 41 (the oldest currently supported Fedora). It has cmake-3.30.8-1.fc41.