szurubooru icon indicating copy to clipboard operation
szurubooru copied to clipboard

Updates to pools UI

Open sgsunder opened this issue 4 years ago • 4 comments

The following are some minor QoL/UI consistency changes that should be made for the pools feature now that it is merged in:

  • [ ] In the post edit display, adding a post to a pool should look like adding a tag (see screenshot) image
  • [x] When displaying pool names, provide an option to display underscores as spaces (just like tags)
  • [ ] Named search token for pool should use the pool name instead of ID
  • [x] Under pool display, show “Aliases” as (none) when no aliases are present, similar to how tags are

@Ruin0x11 would you be able to help me with some of these?

sgsunder avatar Jun 05 '20 01:06 sgsunder

Sure, I can look into it. A few questions.

  • Do we want to create a new pool in the input box if it doesn't exist? If the user changes their mind I think they have to manually go and delete the empty pool instead of tags where the entry is automatically deleted if the last usage is deleted (can't quite remember of the top of my head)
  • Is the option for pool naming per-pool or in the user's config? Or the site's config?

Ruin0x11 avatar Jun 05 '20 22:06 Ruin0x11

For (1): I think it's fine to mirror the tag creation behavior. If you type a new tag into the input box, it doesn't get committed to the server until the user hits save on the post edit. Any committed tags don't get automatically deleted ever. However, if you mistype a tag into the entry box and delete it before hitting save, it never gets committed in the first place.

For (2): If you are talking about the allowable pool name regex, that's set in the site's config. The option to show underscores as spaces should be entirely a client side user preference, stored in a cookie. Again, that mirrors the way tags function.

sgsunder avatar Jun 06 '20 14:06 sgsunder

When you change the order of the pool, it does not reflect the changes in the UI, including pool list and clicking arrow in the post UI.

joshuaavalon avatar Jun 07 '20 10:06 joshuaavalon

@joshuaavalon How do you change the order of the pool? I've been trying to figure out this feature and haven't yet.

TangentFoxy avatar Jul 23 '20 23:07 TangentFoxy