gorqlite icon indicating copy to clipboard operation
gorqlite copied to clipboard

basic support for prepared statements

Open marctrem opened this issue 3 years ago • 5 comments

Please let me know if you like this so I can polish it.

marctrem avatar Jul 21 '21 00:07 marctrem

Yes, thanks -- this functionality is definitely welcome.

otoolep avatar Jul 21 '21 00:07 otoolep

The original author indicated there would be more "polish" to come, so I didn't merge it yet. I would need to examine the code, and determine if it's ready for merging (and that sufficient testing has been put in place).

Is there anyone interested in doing that?

otoolep avatar Sep 13 '22 12:09 otoolep

@otoolep It looks like the author has marked the PR as "ready for review", so I assume that the polishing is done? I can also see that tests have been added. I'm not sure if the author is still active, but if further changes need to me made, I'd be happy to make them and submit a separate PR.

sgalsaleh avatar Sep 15 '22 15:09 sgalsaleh

If you want, take a look at my repo: https://github.com/gandaldf/gorqlite

gandaldf avatar Sep 15 '22 20:09 gandaldf

@gandaldf thank you for the suggestion, I'm about to submit a PR soon of my own with support for both parameterized statements and nullable types. If you're interested, this is how it looks like now: https://github.com/replicatedhq/gorqlite/pull/1

sgalsaleh avatar Sep 16 '22 00:09 sgalsaleh