django-rq icon indicating copy to clipboard operation
django-rq copied to clipboard

Django-RQ already uses sync transport for Sentry

Open justinmayer opened this issue 7 years ago • 5 comments

The Configuring Logging section of the README currently says:

Please configure Raven to use sync+https:// or requests+https:// transport in settings.py [...]

But that configuration produces a deprecation warning:

UserWarning: Transport selection via DSN is deprecated. You should explicitly pass the transport class to Client() instead.

As far as explicitly passing the sync transport class to Client(), it seems that Django-RQ already does that. (HTTPTransport is the sync transport.)

In short, perhaps I'm missing something, but it seems to me that this bit of documentation is out-of-date and should be updated or removed as appropriate.

justinmayer avatar Dec 26 '17 16:12 justinmayer

@efi-mk / @selwin: What do you think?

justinmayer avatar Dec 26 '17 16:12 justinmayer

@justinmayer PR welcome :)

selwin avatar Jan 17 '18 00:01 selwin

Hi. While we are at it, the information about the usage of Raven (for Sentry) is outdated as well.

djmaze avatar Jul 09 '19 16:07 djmaze

Yeah, RQ already switched to using sentry-sdk in version 1.0. Can someone please open a PR to fix this?

selwin avatar Jul 09 '19 23:07 selwin

PR was merged: https://github.com/rq/django-rq/pull/425. We look forward to the release!

kichawa avatar Sep 24 '20 13:09 kichawa