django-rq
django-rq copied to clipboard
Django-RQ already uses sync transport for Sentry
The Configuring Logging section of the README currently says:
Please configure Raven to use sync+https:// or requests+https:// transport in settings.py [...]
But that configuration produces a deprecation warning:
UserWarning: Transport selection via DSN is deprecated. You should explicitly pass the transport class to Client() instead.
As far as explicitly passing the sync
transport class to Client(), it seems that Django-RQ already does that. (HTTPTransport
is the sync transport.)
In short, perhaps I'm missing something, but it seems to me that this bit of documentation is out-of-date and should be updated or removed as appropriate.
@efi-mk / @selwin: What do you think?
@justinmayer PR welcome :)
Hi. While we are at it, the information about the usage of Raven (for Sentry) is outdated as well.
Yeah, RQ already switched to using sentry-sdk
in version 1.0. Can someone please open a PR to fix this?
PR was merged: https://github.com/rq/django-rq/pull/425. We look forward to the release!